[PATCHES] CTDB: clean up recovery lock code

Amitay Isaacs amitay at gmail.com
Thu Feb 12 23:19:33 MST 2015


On Mon, Feb 9, 2015 at 1:13 PM, Martin Schwenke <martin at meltin.net> wrote:

> On Tue, 3 Feb 2015 14:49:21 +1100, Martin Schwenke <martin at meltin.net>
> wrote:
>
> > Attached are a bunch of patches that clean up the CTDB recovery lock
> > code and documentation.
> >
> > The most obvious changes are:
> >
> > * ctdbd aborts with a clear error message if it can take the recovery
> >   lock during recovery, when it should be held by the recovery daemon
> >   on the recovery master node.  This removes any ambiguity about
> >   running with a broken recovery lock.
> >
> > * VerifyRecoveryLock tunable is obsoleted.  If you don't want a
> >   recovery lock then don't set one.
> >
> > * Code cleanups.
> >
> > * Documentation improvements.
>
> Re-pushed to my ctdb-recovery-lock branch with a minor change.
>
> This patch:
>
>   ctdb-daemon: Log a warning when setting obsolete tunables
>
> now logs the warning after setting the variable.  This makes a
> potential future change (return non-zero when setting obsolete variable)
> slightly simpler.  :-)
>
> peace & happiness,
> martin
>

Pushed to autobuild.

Amitay.


More information about the samba-technical mailing list