[PATCH] waf: Fix the build on openbsd

Jelmer Vernooij jelmer at samba.org
Wed Feb 11 10:05:46 MST 2015

On Wed, Feb 11, 2015 at 11:08:15AM +0100, Volker Lendecke wrote:
> On Tue, Feb 10, 2015 at 01:18:56PM -0800, Jeremy Allison wrote:
> > Well that suggestion was based on the assumption
> > that we had decided on *not* changing wafadmin.
> From my point of view this decision is wrong. I've given arguments for
> my opinion abundantly in this thread, the main ones are traceability of
> changes with version control and clarity of code. Also, if I was about to
> import a new version of waf, I *wanted* git to complain about conflicts,
> I would have no chance to scan all of wafsamba/wscript/wscript_build
> for potential binary patches.

Aside from the discussion of how to carry local changes, why do we need to
carry local changes in this situation at all?

We introduced this bug by sending a patch to upstream, and
so it seems reasonable to also help fix the regression caused by that
patch there.

As far as I know we don't want (or at least strongly prefer not) to have
Samba-specific changes in our copies of e.g. zlib or popt. Why is waf any



More information about the samba-technical mailing list