Samba 4.2 and Microsoft Lease test cases

[Jeremy Allison]

On Tue, Feb 10, 2015 at 09:54:43PM -0600, Steve French wrote:
> So looking at the failure of one of these (test 874 from the Microsoft
> suite) against current Samba 4.2-stable - I do see the "STATUS
> UNSUCCESSFUL" in the wireshark trace as the log implied I would
> 
> 2015-02-10 21:51:08.494 [Comment] reaching state 'S831'
> 2015-02-10 21:51:08.501 [Comment] checking step 'event
> OnLeaseBreakNotification(0,SMB2_NOTIFY_BREAK_LEASE_FLAG_ACK_REQUIRED,3,1)'
> 2015-02-10 21:51:08.501 [CheckSucceeded] Assert.IsTrue succeeded.
> expected '0', actual '0' (newEpoch of OnLeaseBreakNotification, state
> S831)
> 2015-02-10 21:51:08.502 [CheckSucceeded] Assert.IsTrue succeeded.
> expected 'SMB2_NOTIFY_BREAK_LEASE_FLAG_ACK_REQUIRED', actual
> 'SMB2_NOTIFY_BREAK_LEASE_FLAG_ACK_REQUIRED' (flags of
> OnLeaseBreakNotification, state S831)
> 2015-02-10 21:51:08.510 [CheckSucceeded] Assert.IsTrue succeeded.
> expected '3', actual '3' (currentLeaseState of
> OnLeaseBreakNotification, state S831)
> 2015-02-10 21:51:08.511 [CheckSucceeded] Assert.IsTrue succeeded.
> expected '1', actual '1' (newLeaseState of OnLeaseBreakNotification,
> state S831)
> 2015-02-10 21:51:08.513 [Checkpoint] "[MS-SMB2] 3.3.4.7: Otherwise the
> server MUST set the Flags field of the message to
> SMB2_NOTIFY_BREAK_LEASE_FLAG_ACK_REQUIRED, indicating to the client
> that lease acknowledgment is required."
> 2015-02-10 21:51:08.514 [Checkpoint] "[TestInfo] Lease.LeaseState is
> not SMB2_LEASE_READ_CACHING."
> 2015-02-10 21:51:08.515 [Checkpoint] "[MS-SMB2] The server MUST set
> the CurrentLeaseState field of the message to Lease.LeaseState, set
> Lease.Breaking to TRUE, set Lease.BreakToLeaseState to the new lease
> state indicated by the object store"
> 2015-02-10 21:51:08.516 [Comment] reaching state 'S832'
> 2015-02-10 21:51:08.517 [Comment] executing step 'call
> LeaseBreakAcknowledgmentRequest(ValidLeaseKey,1)'
> 2015-02-10 21:51:08.536 [CheckSucceeded] Assert.AreEqual succeeded.
> Expect that the Command is OPLOCK_BREAK.
> 2015-02-10 21:51:08.537 [Comment] Unbinding variable 'leaseState'
> 2015-02-10 21:51:08.537 [Comment] reaching state 'S833'
> 2015-02-10 21:51:08.538 [Comment] checking step 'return
> LeaseBreakAcknowledgmentRequest'
> 2015-02-10 21:51:08.538 [Comment] reaching state 'S834'
> 2015-02-10 21:51:08.545 [CheckFailed] Assert.IsTrue failed. expected
> matching event, found 'event
> LeaseBreakResponse(STATUS_UNSUCCESSFUL,0)'. Diagnosis:
>   1. event parameters do not match
>     comment: checking step 'event LeaseBreakResponse(STATUS_SUCCESS,1)'
>     assert  failed: expected 'STATUS_SUCCESS', actual
> 'STATUS_UNSUCCESSFUL' (status of LeaseBreakResponse, state S834)
>     comment: This step would have covered "[MS-SMB2] The server MUST
> locate the lease on which the client is acknowledging a lease break by
> performing a lookup in LeaseTable.LeaseList using the LeaseKey of the
> request as the lookup key.", "[MS-SMB2] The server MUST set
> Lease.LeaseState to LeaseState received in the request, and MUST set
> Lease.Breaking to FALSE.", "[MS-SMB2] The server then MUST construct a
> lease break response using the syntax specified in section 2.2.25 with
> the following values:", "[MS-SMB2] LeaseState MUST be set to
> Lease.LeaseState."

Yeah, I need to see the smbd logs of this, not the
Microsoft ones.