[PATCH] waf: Fix the build on openbsd

Ralph Böhme rb at sernet.de
Mon Feb 9 09:38:58 MST 2015


On Mon, Feb 09, 2015 at 05:12:16PM +0100, Jelmer Vernooij wrote:
> On Mon, Feb 09, 2015 at 02:59:29PM +0100, Volker Lendecke wrote:
> > On Mon, Feb 09, 2015 at 02:43:31PM +0100, Jelmer Vernooij wrote:
> > > On Mon, Feb 09, 2015 at 02:09:17PM +0100, Volker Lendecke wrote:
> > > > On Mon, Feb 09, 2015 at 12:41:56PM +0100, Ralph Böhme wrote:
> > > we lose all Samba-specific changes. Changes that are generic enough
> > > to go into wafadmin/ should really go upstream, so we can pull them down
> > > from there.
> > 
> > My understanding is that going through upstream is not an option for us
> > because we're far too backlevel, and as Ralph has pointed out upstream
> > is not very open to changes from us.
> 
> Upstream has accepted patches from us, and helped fix issues we run into. I'm
> happy to help if there are any specific patches you have trouble getting
> upstreamed.

I think we're fighting with a different problem here, not just whether
to submit patches upstream or not, but where to apply patches
here/downstream while upstream may need an arbitrary long time to
accept patches, if at all.

My own fix ga6bda1f2bc85779feb9680bc74821da5ccd401c5 is another good
example: would have been a one line change in wafadmin. As I'd been
told to stay away from wafadmin, I developped this patch together with
metze. The basic recipe is the same across several patches from metze
and Michael.

Upstream bugreport:
<https://code.google.com/p/waf/issues/detail?id=1505>

Looks like it's been accepted/candidate for 1.9.

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de


More information about the samba-technical mailing list