[PATCH] waf: Fix the build on openbsd

Ralph Böhme rb at sernet.de
Tue Feb 3 06:44:20 MST 2015

On Tue, Feb 03, 2015 at 01:59:22PM +0100, Volker Lendecke wrote:
> On Tue, Feb 03, 2015 at 01:46:39PM +0100, Ralph Böhme wrote:
> > patch attached. Of course completely untested. :)
> To me this looks as if we duplicate code that is just buggy in
> wafadmin.

But that "duplicate code" contains the fix.

> We should contact waf upstream to fix it, right?

Been there, done that, not going there again.

> BTW, this bug was introduced with a commit message that said
> "wafadmin: backported the openbsd fixes from waf 1.7"
> What about just reverting this broken backport of a fix that isn't?

Are you sure it's broken? To me it looks like it's just single bug in
one place that you've come across. But as the backport is from Michael
and metze, maybe either one of em can shed some light on this.

If the bug is in an *existing* patch to wafadmin, imho we may as well
simply apply your original patch, possibly with an ammended commit
message with a reference to the broken commit, shall we ?


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

More information about the samba-technical mailing list