[PATCH 6/8] urgent_replication: Use subunit reporting, remove allow_empty_output.
jelmer at samba.org
Sun Feb 1 13:23:10 MST 2015
On Sun, Feb 01, 2015 at 12:39:43PM +0100, Stefan (metze) Metzmacher wrote:
> Hi Jelmer,
> >> This means LDAP:// might also be supposed to work, but
> >> ldb_module_connect_backend() only handles 'ldap://'.
> >> I'm also fine with removing only the "samdb_url = samdb_url.lower()" line
> >> and drop support for 'LDAP://'.
> > I think only handling ldap:// would be fine. I think it's actually
> > most important that we're consistent in what we support across the
> > Python and the C code.
> I tend to agree.
> I changed the patch to only remove the .lower().
> > startswith() is a terrible way of parsing URLs ;) The 'urlparse'
> > module (bundled with Python) in Python is probably better for parsing
> > the URL and extracting the scheme.
> Feel free to improve it:-)
> Can you review the attached to patches?
Reviewed-By: Jelmer Vernooij <jelmer at samba.org>
Jelmer Vernooij <jelmer at samba.org> - https://jelmer.uk/
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: Digital signature
More information about the samba-technical