[PATCH] fix copy'n'paste error in smb2:durable-open test
Jeremy Allison
jra at samba.org
Tue Dec 29 04:29:48 UTC 2015
On Tue, Dec 29, 2015 at 01:13:01AM +0100, Michael Adam wrote:
> Hi,
>
> see attached. Review / push appreciated.
>
> Thanks - Michael
LGTM. Pushed - thanks !
> From 108a2457348f33f1fb5f0a8f3bf3db66050cad29 Mon Sep 17 00:00:00 2001
> From: Michael Adam <obnox at samba.org>
> Date: Tue, 29 Dec 2015 00:44:11 +0100
> Subject: [PATCH] torture:smb2: fix copy'n'paste error in
> durable-open:open2:lease test
>
> Checking against the correct smb2_create object also lets us
> check the correct create action (EXISTED vs CREATED).
>
> Observed when this showed up in flakey test results.
>
> Signed-off-by: Michael Adam <obnox at samba.org>
> ---
> source4/torture/smb2/durable_open.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/source4/torture/smb2/durable_open.c b/source4/torture/smb2/durable_open.c
> index bb32f96..fe0a326 100644
> --- a/source4/torture/smb2/durable_open.c
> +++ b/source4/torture/smb2/durable_open.c
> @@ -2112,7 +2112,7 @@ static bool test_durable_open_open2_lease(struct torture_context *tctx,
> status = smb2_create(tree2, mem_ctx, &io2);
> CHECK_STATUS(status, NT_STATUS_OK);
> h2 = io2.out.file.handle;
> - CHECK_CREATED(&io1, CREATED, FILE_ATTRIBUTE_ARCHIVE);
> + CHECK_CREATED(&io2, EXISTED, FILE_ATTRIBUTE_ARCHIVE);
>
> /* Reconnect */
> if (!torture_smb2_connection_ext(tctx, 0, &options, &tree1)) {
> --
> 2.5.0
>
More information about the samba-technical
mailing list