[PATCH] smbd: stop disabling "store dos attributes" on-the-fly

[Uri Simchoni]

Thanks for spotting this!

I noticed the discussions on that improvement but somehow skipped the 
fact that it was already implemented :)

Attaching the fixup...
Uri

On 12/27/2015 12:14 AM, Christof Schmitt wrote:
> Hi Uri,
>
> i noticed that the patch is already in master, but please see below for a
> comment on the messages. Maybe you could post a follow-on patch to remove the
> function name.
>
> Christof
>
>> +		DBG_INFO("get_ea_dos_attribute: Cannot get attribute "
>> +			 "from EA on file %s: Error = %s\n",
>> +			 smb_fname_str_dbg(smb_fname), strerror(errno));
> Minor comment: DBG_INFO in master already prepends the function name, there is
> no need to explicitly add it. You need to add it in the backport.
>
>

-------------- next part --------------
>From 3b778be52dbaf0c7f8895c79b372986873fd62b4 Mon Sep 17 00:00:00 2001
From: Uri Simchoni <uri at samba.org>
Date: Sun, 27 Dec 2015 07:17:58 +0200
Subject: [PATCH] smbd: remove function name from a DBG_INFO in a recent commit

We now have <function_name:> embedded automatically into DBG_XXX-
generated messages.

Signed-off-by: Uri Simchoni <uri at samba.org>
---
 source3/smbd/dosmode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source3/smbd/dosmode.c b/source3/smbd/dosmode.c
index 942d286..ecc211c 100644
--- a/source3/smbd/dosmode.c
+++ b/source3/smbd/dosmode.c
@@ -279,7 +279,7 @@ static bool get_ea_dos_attribute(connection_struct *conn,
 				   SAMBA_XATTR_DOS_ATTRIB, attrstr,
 				   sizeof(attrstr));
 	if (sizeret == -1) {
-		DBG_INFO("get_ea_dos_attribute: Cannot get attribute "
+		DBG_INFO("Cannot get attribute "
 			 "from EA on file %s: Error = %s\n",
 			 smb_fname_str_dbg(smb_fname), strerror(errno));
 		return False;
@@ -413,7 +413,7 @@ static bool set_ea_dos_attribute(connection_struct *conn,
 		files_struct *fsp = NULL;
 
 		if((errno != EPERM) && (errno != EACCES)) {
-			DBG_INFO("set_ea_dos_attributes: Cannot set "
+			DBG_INFO("Cannot set "
 				 "attribute EA on file %s: Error = %s\n",
 				 smb_fname_str_dbg(smb_fname), strerror(errno));
 			return false;
-- 
2.4.3