[PATCH] Don't use labs() on an unsigned values

Jeremy Allison jra at samba.org
Wed Dec 23 07:08:28 UTC 2015


On Wed, Dec 23, 2015 at 08:00:07PM +1300, Douglas Bagnall wrote:
> On 23/12/15 19:45, Jeremy Allison wrote:
>  
> > If you fix the spacing to look like:
> > 
> >  +     /* Samba's NTTIME is unsigned, abs() won't work! */
> >  +     if (nt0 > nt1) {
> >  +             ret = nt0 - nt1;
> >  +     } else {
> >  +             ret = nt1 - nt0;
> >  +     }
> > 
> > so it matches the way we use braces and spacing, then:
> 
> That is exactly what Garming said!

Well obviously great minds think alike :-). Feel
free to push Garming :-).



More information about the samba-technical mailing list