[PATCH] Don't use labs() on an unsigned values

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Wed Dec 23 07:00:07 UTC 2015


On 23/12/15 19:45, Jeremy Allison wrote:
 
> If you fix the spacing to look like:
> 
>  +     /* Samba's NTTIME is unsigned, abs() won't work! */
>  +     if (nt0 > nt1) {
>  +             ret = nt0 - nt1;
>  +     } else {
>  +             ret = nt1 - nt0;
>  +     }
> 
> so it matches the way we use braces and spacing, then:

That is exactly what Garming said!

thanks,
Douglas




More information about the samba-technical mailing list