[PATCH] Patch for bug 11347

Jeremy Allison jra at samba.org
Tue Dec 22 16:50:12 UTC 2015


On Tue, Dec 22, 2015 at 10:57:48AM +0100, Stefan Metzmacher wrote:
> Hi Ralph,
> 
> > Attached is a somewhat largish patchset for bug 11347.
> > 
> > The first 13 patches are mostly cleanup for the torture test and
> > making sure the test not only works against Samba running on the same
> > host but also against any remote server including the OS X SMB server.
> > 
> > Then comes a patch that adds a mapping EOVERFLOW to
> > NT_STATUS_ALLOTTED_SPACE_EXCEEDED to errmap_unix. I need this because
> > some SMB layer ftruncate requests have to be rejected with this NT
> > error code.
> 
> Please remove the mapping again, when the switch to NTSTATUS is done,
> otherwise we'll never get rid of it again as nobody will remember what
> we might break if we remove it or change it to something more intuitive
> like NT_STATUS_INTEGER_OVERFLOW in future.
> 
> It's already a problem to merge map_nt_error_from_unix_common()
> and map_nt_error_from_unix() because we may break something.

Oh yes, once the conversion to NTSTATUS is in place we
can clean out all strange errno -> NTSTATUS mappings.



More information about the samba-technical mailing list