Samba DEBUG in OpenChange

[Volker Lendecke]

On Mon, Dec 14, 2015 at 08:49:53PM +1300, Andrew Bartlett wrote:
> On Mon, 2015-12-14 at 08:39 +0100, Volker Lendecke wrote:
> > On Mon, Dec 14, 2015 at 03:27:47PM +1300, Andrew Bartlett wrote:
> > > To be clear, it was public.  We broke that promise.
> > 
> > Where did we make that promise?
> 
> See lib/util/wscript_build:
> 
> public_headers='debug.h'
> 
> That, and the almost 50 public Samba releases with debug.h installed as
> a public header.  Indeed, it still is.
> 
> I'm sorry this wasn't reverted as soon as the issue was noticed, but is
> there a good technical reason we can't put things back the way they
> where?  This has gone on long enough.

From lib/util/wscript_build:

public_headers='debug.h attr.h byteorder.h data_blob.h memory.h safe_string.h time.h talloc_stack.h xfile.h dlinklist.h samba_util.h string_wrappers.h idtree.h idtree_random.h blocking.h signal.h substitute.h fault.h genrand.h'
public_headers='tevent_ntstatus.h tevent_werror.h'

Other place:

public_headers='include/smbldap.h include/smb_ldap.h'
public_headers='error.h ntstatus.h doserr.h werror.h hresult.h'

I mean, we publish samba_util.h, the very definition of a
kitchen sink. Do you really mean to seriously publish this
as an API???

If this is the defintion of an API promise, we are so beyond
fucked that our ONLY chance is to fork. Now.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de