[PATCH] ctdb-ipalloc: Split IP allocation into its own build subsystem
Amitay Isaacs
amitay at gmail.com
Thu Dec 10 15:49:37 UTC 2015
On Thu, Dec 10, 2015 at 8:58 PM, Martin Schwenke <martin at meltin.net> wrote:
> Please review and push...
>
> peace & happiness,
> martin
>
Hi Martin,
We still have functions that use ipalloc_state other than the top-level
allocation routine ipalloc(). May be it's worthwhile adding a comment on
the steps involved in the ctdb_takeover_run().
Also, separting of the ip allocation routines now makes some of the
previously static functions non-static (e.g. node_ip_coverage). It might
be better to rename all those functions with "ipalloc_" prefix even though
those functions are only used in recovery daemon. Those could be extra
patches on top of the split-up work.
Amitay.
More information about the samba-technical
mailing list