[PATCH] DRAFT: Add new test which covers force user bug

[Andrew Bartlett]

On Tue, 2015-12-08 at 21:48 +0100, Andreas Schneider wrote:
> On Tuesday 08 December 2015 16:50:33 Robin Hack wrote:
> > Hi Andrew.
> > 
> > Thank you for your time.
> > 
> > New patch is attached.
> > 
> > Changes:
> > * test were moved to map_to_guest env.
> > * test were renamed to samba3.blackbox.smbclient.forceuser
> > 
> > On Fri, Dec 4, 2015 at 9:26 PM, Andrew Bartlett <abartlet at samba.org
> > > wrote:
> > > > Attached file is my first try to rewrite test to shape
> > > > acceptable by
> > > > Samba
> > > > upstream. Please. Be patient. It's not easy to add new tests to
> > > > Samba
> > > > upstream testsuite :(.
> > > 
> > > We also welcome contributions to how we build tests.  I'm open to
> > > reasonable extra dependencies (with the understanding that we use
> > > subunit v1 as our test reporting language)
> > 
> > What I miss now is some glue library for tests written in shell.
> > For example:  run_cmd_nooutput() can be shared among tests etc..
> > Actually some perl setup library would be nice too. What do you
> > think?
> > 
> > > Can you run those against a specific share in the existing
> > > map_to_guest
> > > environment, rather than needing a whole new environment?
> > > 
> > > Yes :). Thank you for hint. I moved test in attached patch to
> > > map_to_guest.
> > > 
> > > 
> > > Also please take care where you place your test.  The python
> > > block
> > > currently covering "for env in ["fileserver"] extends to below
> > > the TAR
> > > tests, and you have moved those tests into "forceuser".
> > > 
> > > Thank you.
> > 
> >  test.py file is little bit mystery for me now. I moved test to
> > maptoguest
> > env. I hope that for loop should be here and I also hope I didn't
> > broke it
> > again.
> > 
> > > Other than that, it looks like you are on the right track, and
> > > I'm
> > > really keen to help you improve our testsuite.
> > 
> > Great!
> > 
> > Have nice day.
> 
> Looks fine for me.

Looks good to me too.  Thanks for your patience!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba