Questions about smbd option "strict rename"

[Jeremy Allison]

On Mon, Nov 30, 2015 at 07:01:07PM +0100, Ralph Boehme wrote:
> > >>>>> them with VFS_ so they won't collide with flags we may add later on
> > >>>>> for SMB2/3 UNIX extensions.
> > >>>>
> > >>>> Hmmm. Don't like VFS_ as they're not really VFS. How about
> > >>>> FSP_ prefix as they're more to do with fsp open handles ?
> > >>>
> > >>> perfect, thanks!
> > >>>
> > >>> Updated patchset attached. I've added a test that verifies both
> > >>> possibilities: deny rename if POSIX rename cap is not enabled, permit
> > >>> rename if POSIX rename cap is enabled via AAPL/vfs_fruit.
> > >>
> > >> Can we make change from bool posix_open to uint8_t posix_flags first?
> > >> Maybe with a #define posix_open posix_flags.
> > > 
> > > excellent idea! Something like the attached patch?
> > 
> > Except that we need to allow renames with just the _OPEN flags
> > specified (for the backports).
> 
> thanks for spotting this! Updated patchset attached.

Really nice work Ralph, thanks ! Pushed.