[PATCH] Renaming a printer fails in Printer Management Console

David Disseldorp ddiss at suse.de
Mon Aug 31 22:06:58 UTC 2015

Hi Garming,

On Fri, 28 Aug 2015 14:06:31 +1200, Garming Sam wrote:

> Hi,
> This is patch (with some additional allocation checks) I wrote late last 
> year that was somewhat forgotten about. It fixes bug 10770, which 
> explains that Samba doesn't allow renaming of a printer using the F2 key.
> What was missing was the info level 4 call of _spoolss_SetPrinter, and 
> here I've just retrieved the old printer, filled it in and used the 
> update_printer_call which takes struct info level 2. I previously tried 
> removing some of the additional talloc calls, but it seemed more trouble 
> than it was worth at the time with some parts freeing somewhat unexpectedly.
> Please review and push.
> https://bugzilla.samba.org/show_bug.cgi?id=10770

Looks like I'm a little late here. Nevertheless, it looks as though
there are a few error paths that don't clean up tmp_ctx. Also, it's
probably worth splitting this logic into a separate function.
Otherwise I think it looks good, and these minor nits can be addressed
after Jeremy's push goes in.

Thanks for your work on this!

Cheers, David

More information about the samba-technical mailing list