[PATCH] vfs_gpfs: Check offline bit only when HSM is configured

Christof Schmitt cs at samba.org
Mon Aug 31 17:53:51 UTC 2015

We might also need to look into handling the offline flag better in a
later patch, but the current patch should be obvious: Without HSM, files
can never be offline, and the queries for the offline flag can be

-------------- next part --------------
From c7c1f7e22166b4be72294a89a4261de1747c237b Mon Sep 17 00:00:00 2001
From: Christof Schmitt <cs at samba.org>
Date: Fri, 28 Aug 2015 14:22:40 -0700
Subject: [PATCH] vfs_gpfs: Check offline bit only when HSM is configured

Querying the offline bit is just unnecessary overhead when HSM is not

Signed-off-by: Christof Schmitt <cs at samba.org>
 source3/modules/vfs_gpfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/source3/modules/vfs_gpfs.c b/source3/modules/vfs_gpfs.c
index 3e593e1..ac840b7 100644
--- a/source3/modules/vfs_gpfs.c
+++ b/source3/modules/vfs_gpfs.c
@@ -1929,7 +1929,7 @@ static bool vfs_gpfs_is_offline(struct vfs_handle_struct *handle,
 				struct gpfs_config_data,
 				return -1);
-	if (!config->winattr) {
+	if (!config->winattr || !config->hsm) {
 		return SMB_VFS_NEXT_IS_OFFLINE(handle, fname, sbuf);

More information about the samba-technical mailing list