Compiler errors on ubuntu 14.04 (svhdx changes)
jra at samba.org
Fri Aug 28 21:03:16 UTC 2015
On Sat, Aug 29, 2015 at 08:47:27AM +1200, Andrew Bartlett wrote:
> On Fri, 2015-08-28 at 08:53 -0700, Jeremy Allison wrote:
> > On Fri, Aug 28, 2015 at 02:19:24PM +0200, Stefan Metzmacher wrote:
> > > Hi,
> > >
> > > can someone please push this fix?
> > >
> > > It's required when using --pick-developer on ubuntu 14.04.
> > Should we be running autobuilds with --picky-developer
> > too ?
> I think what is happening here is that metze is trying to prove we can
> run autobuilds with ubuntu 14.04 (rather than the older OS we have used
> to date) and so came across this. This is similar to the efforts
> Catalyst has been doing running builds on 32 bit, 14.04 and 15.04, and
> perhaps one day I'll get us automatically building on those too.
> The fix itself seems rather ugly - are we really leaving #if 0 in the
> code long term?
Yes I agree it's ugly, I would probably have just
removed that code. But I see his point in keeping
the pointer around until we decide whether the
upper layer needs to access this longer term
(i.e. ok for master, needs fixing for release).
More information about the samba-technical