[PATCHES] Port ldb to Python 3
metze at samba.org
Thu Aug 27 13:22:10 UTC 2015
Am 26.08.2015 um 03:53 schrieb Andrew Bartlett:
> On Mon, 2015-08-24 at 16:06 +0200, Stefan Metzmacher wrote:
>>> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>>> Metze, I think your concerns have been addressed, do you have any
>>> further comments?
>> Yes, looks good now.
>>> Can I get a second team reviewer please?
>> I've everything reviewed in my master3-python branch:
>> I'll push it to master once I've sorted our some
>> fixes in other libraries, so that I can do a releases
>> of talloc, tdb, tevent and ldb.
> Do you want to include the patches to ldb for ldb_unpack_data_withlist
> (See: [PATCH] More tdb/ldb tests) while bumping the version?
I'll have a look.
>> Can someone check if the compilation of all 4 libraries work
>> on FreeBSD? This is in order to address:
> It failed on FreeBSD 9 with:
> ../source3/locking/share_mode_lock.c:136: error: type qualifiers ignored on function return type
> A patch is attached.
> Andrew Bartlett
I'll push that one.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: OpenPGP digital signature
More information about the samba-technical