New python PIDL checks cause 2221 new Coverity warnings

Andrew Bartlett abartlet at
Thu Aug 27 04:16:19 UTC 2015

On Wed, 2015-08-26 at 15:02 +0000, Green, Paul wrote:
> Careful!  That's not funny.  I'm also concerned that talking about 
> "32-bit systems" is vague and confusing.
> For example, here at Stratus, we port and maintain Samba on a 32-bit
> -based operating system. But saying that we have a 32-bit system 
> doesn't tell the whole story. Our kernel supports a mixture of 32-bit 
> and 64-bit primitives. For example, our GCC/POSIX environment has 
> full 64-bit integers (long long, int64_t), 64-bit file offsets 
> (off_t), and so on. We have successfully built Samba 4.x and it is 
> working fine.
> Perhaps you are thinking of systems without any 64-bit integers. I 
> could see that could be a problem. Maybe C unions or C++ classes 
> would offer a cleaner solution. If people have GCC, then they should 
> also have G++.

In this case, what matters is sizeof(long) and therefore LONG_MAX, as
Python's Int is based on that.

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team
Samba Development and Support, Catalyst IT

More information about the samba-technical mailing list