[PATCHES] Port ldb to Python 3

Andrew Bartlett abartlet at samba.org
Wed Aug 26 01:53:29 UTC 2015

On Mon, 2015-08-24 at 16:06 +0200, Stefan Metzmacher wrote:
> Hi,
> > Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> > 
> > Metze, I think your concerns have been addressed, do you have any
> > further comments?
> Yes, looks good now.
> > Can I get a second team reviewer please?
> I've everything reviewed in my master3-python branch:
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/
> master3-python
> I'll push it to master once I've sorted our some
> fixes in other libraries, so that I can do a releases
> of talloc, tdb, tevent and ldb.

Do you want to include the patches to ldb for ldb_unpack_data_withlist
(See: [PATCH] More tdb/ldb tests) while bumping the version?

> Can someone check if the compilation of all 4 libraries work
> on FreeBSD? This is in order to address:
> https://bugzilla.samba.org/show_bug.cgi?id=11455
> and
> https://bugzilla.samba.org/show_bug.cgi?id=11457

It failed on FreeBSD 9 with:
../source3/locking/share_mode_lock.c:136: error: type qualifiers ignored on function return type
A patch is attached.
Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-source3-locking-Fix-build-on-FreeBSD.patch
Type: text/x-patch
Size: 1071 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150826/8f8b3a7b/0001-source3-locking-Fix-build-on-FreeBSD.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150826/8f8b3a7b/signature.sig>

More information about the samba-technical mailing list