[PATCHES] Small cleanup for nfs4_acls.c

[Ralph Böhme]

On Mon, Aug 24, 2015 at 09:58:12PM +0200, Ralph Böhme wrote:
> On Mon, Aug 24, 2015 at 11:59:00AM -0700, Christof Schmitt wrote:
> > On Mon, Aug 24, 2015 at 07:25:24AM +0200, Volker Lendecke wrote:
> > > On Sun, Aug 23, 2015 at 10:00:24PM -0700, Christof Schmitt wrote:
> > > > On Sun, Aug 23, 2015 at 09:53:10PM +0200, Ralph Boehme wrote:
> > > > > Hi Christof,
> > > > > 
> > > > > all reviewed-by: me.
> > > > > 
> > > > > -Ralph
> > > > 
> > > > Thank you. Pushed to autobuild.
> > > 
> > > I had pushed them too. But for me they failed to build
> > > because nfs4acls can't find sid2gid & friends. Does that
> > > succeed for you?
> > 
> > It only worked since i forgot to enable the picky checks in the build.
> > The problem was the removal of the passdb/lookup_sid.h include that is
> > still required. See the attached updated patches.
> 
> reviewed&built&pushed.

got an error in autobuild which looks like something may be fishy in
the patchset:

Testing Printer Security Descriptors
Testing GetPrinter level 2
WARNING!: ../source4/torture/rpc/spoolss.c:1210:
dcerpc_spoolss_GetPrinter_r(b, tctx, &r) was
NT_STATUS_EPT_CANT_PERFORM_OP, expected NT_STATUS_OK: GetPrinter
failed
WARNING!: ../source4/torture/rpc/spoolss.c:2048: Expression
`test_GetPrinter_level(tctx, b, handle, 2, &info)' failed: failed to
get initial security descriptor
UNEXPECTED(failure):
samba3.rpc.spoolss.printer.addprinterex.sd(nt4_dc)
REASON: Exception: Exception: ../source4/torture/rpc/spoolss.c:8409:
Expression `test_PrinterInfo_SD(tctx, b, &t->handle)' failed: failed
to test security descriptors

Log:
https://git.samba.org/slow/samba-autobuild/samba.stdout

Can you check that?

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de