[PATCH] More tdb/ldb tests.

[Adrian Cochrane]

I've now tidied up Matthieu Patou's patches.

On Fri, Aug 21, 2015 at 6:05 PM, Volker Lendecke 
<Volker.Lendecke at SerNet.DE> wrote:
> On Fri, Aug 21, 2015 at 01:49:28PM +1200, Andrew Bartlett wrote:
>>  On Fri, 2015-08-21 at 13:27 +1200, Adrian Cochrane wrote:
>>  > I think I addressed all your issues with this code.
>> 
>>  Thanks.
>> 
>>  Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>> 
>>  Can I get a second team reviewer please?
> 
> Two comments: First, in ldb_unpack_data_withlist we can live
> without the "filter" boolean. If you want to protect against
> "list==NULL" but "list_size!=0" just do a
> 
> if (list == NULL) { list_size = 0; }
> 
> Second, parts of the patch go way beyond the 80-char limit.
> I think introducing a helper variable might be overdue here.
> 
> Volker
> 
> --
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:kontakt at sernet.de
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ldb-introduce-ldb_unpack_data_withlist-to-unpack-par.patch
Type: text/x-patch
Size: 7547 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150825/c58282cb/0002-ldb-introduce-ldb_unpack_data_withlist-to-unpack-par.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ldif-increment-version-due-to-added-ldb_unpack_data_.patch
Type: text/x-patch
Size: 22211 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150825/c58282cb/0003-ldif-increment-version-due-to-added-ldb_unpack_data_.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-ldb-torture-test-ldb_unpack_data_withlist.patch
Type: text/x-patch
Size: 6986 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150825/c58282cb/0004-ldb-torture-test-ldb_unpack_data_withlist.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ldb-torture-Test-ldb-unpacking-and-printing.patch
Type: text/x-patch
Size: 27022 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150825/c58282cb/0001-ldb-torture-Test-ldb-unpacking-and-printing.bin>