[PATCH] Simplify idmap initialization for xid2sid

Stefan Metzmacher metze at samba.org
Mon Aug 24 07:26:07 UTC 2015

Hi Volker,

> On Thu, Aug 20, 2015 at 09:59:53PM +0200, Volker Lendecke wrote:
>> The last patch in this patchset changes idmap
>> initialization. The goal is to remove the domain name
>> dependency in finding an idmap domain.
>> I've looked at this code while working on a bulk xids2sids
>> call, which would be greatl simplified when it is able to
>> just send xids down to the idmap child instead of requiring
>> names for everything.
>> A second effect is that we remove one dependency on the
>> unreliable domain list in the winbind parent.
> Attached find a patchset that explains why I'm doing this:
> The last patch removes the "have_idmap_config" from struct
> winbindd_domain.
> Review appreciated!

Overall this patchset looks like a great improvement, thanks!
I've just a few comments:

- Why the wi_ prefix for wi_scan_global_parametrics()
  wouldn't lp_scan_global_parametrics() make more sense?
  As all other functions in loadparm.c start with lp_.
  The first line in the commit message should also match the full
function name.
  Can you change that or explain why you prefer wi_?

- Shouldn't idmap_init fail if wi_scan_global_parametrics() returns an

- I don't understand how default_idmap_domain and passdb_idmap_domain
  endup in idmap_domains[]. Looking further in the existing code this
might be by design.
  idmap_found_domain_backend() ignores the default
  domain, but shouldn't it also ignore the passdb_idmap_domain.
  Can you explain a bit?

- How do we handle the default domain range in
  if default_idmap_domain is not part of idmap_domains[]?

I guess this fixes real bugs, so should we backport this at least to 4.3
(doesn't need to
be 4.3.0). If so can you please create a bug report and add the url to
the commit messages?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150824/161f2c43/signature.sig>

More information about the samba-technical mailing list