[PATCHES] Port ldb to Python 3

[Andrew Bartlett]

On Fri, 2015-08-21 at 10:59 +0200, Petr Viktorin wrote:
> On 08/17/2015 01:17 AM, Andrew Bartlett wrote:
> > On Fri, 2015-08-14 at 13:07 +0200, Petr Viktorin wrote:
> > > 
> > > Thanks.
> > > 
> > > Here is a new version of the patchset. It includes a buildtools 
> > > change
> > > to replace the ABI tag by just ".py3". See the first patch.
> > > 
> > > I've also moved the wscript patch to the end as discussed earlier 
> > > in
> > > this thread, and I've squashed in Stefan's const-correctness 
> > > fixes.
> > 
> > In the tests, can you extend the api.py testsuite to cover the 
> > whole
> > API?
> > 
> > I realise you didn't add the APIs in the first place, but I'm
> > particularly concerned that the intersection between DNs and 
> > LdbValue
> > elements (which mix up between UTF8 strings and binary values in 
> > this
> > new world) could be a bit tricky.  We need tests that specifically 
> > aim
> > for the difficult parts of this, for:
> >  - ldb.Dn.{get,set}_{extended_,}component_{name,value}
> >  - ldb.Dn.{get,set}_rdn_{name,value}
> >  - ldb.Dn.get_casefold
> >  - ldb.Dn.get_linearized
> >  - ldb.Dn.canonical_str
> > 
> > (There are probably more missing tests, but these would seem to be 
> > the
> > main string related tests).
> 
> Thanks for noticing!
> 
> I went with tests when checking my changes, so I overlooked that the
> Dn.set_component family should take both strings and bytes, and
> get_component should return text.
> 
> I added a function to register a dummy extension to make it possible 
> to
> write the extended_component tests.
> I also fixed firstmodule and wrote tests for it.
> 
> These patches go on top of the earlier ones; I can squash if that 
> would
> make it easier for you to review.

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Metze, I think your concerns have been addressed, do you have any
further comments?

Can I get a second team reviewer please?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba