[PATCHES] Port ldb to Python 3
pviktori at redhat.com
Fri Aug 21 09:43:34 UTC 2015
On 08/14/2015 10:09 PM, Andrew Bartlett wrote:
> On Fri, 2015-08-14 at 13:07 +0200, Petr Viktorin wrote:
>> Here is a new version of the patchset. It includes a buildtools
>> to replace the ABI tag by just ".py3". See the first patch.
>> I've also moved the wscript patch to the end as discussed earlier in
>> this thread, and I've squashed in Stefan's const-correctness fixes.
> I'm just trying to understand how this got into our build system. Was
> it via the bld.pyembed_libname?
The buildsystem tracks files by name, so when building for two different
Pythons I needed a way to differentiate them.
So I used the ABI tag that Python uses for its extensions.
For the extensions (e.g. pyldb) it's added automatically – nothing is
linked with them, so the exact name is not relevant for the rest of the
For utility libraries (like pyldb-util), the name ends up in another
file's "deps". I used pyembed_libname to make things explicit.
> That said, it looks like a reasonably elegant solution to the issue.
> I'll do more review next week if this isn't sorted out between now and
> Andrew Bartlett
More information about the samba-technical