[PATCH] More tdb/ldb tests.

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Aug 21 06:05:07 UTC 2015

On Fri, Aug 21, 2015 at 01:49:28PM +1200, Andrew Bartlett wrote:
> On Fri, 2015-08-21 at 13:27 +1200, Adrian Cochrane wrote:
> > I think I addressed all your issues with this code. 
> Thanks.
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> Can I get a second team reviewer please?

Two comments: First, in ldb_unpack_data_withlist we can live
without the "filter" boolean. If you want to protect against
"list==NULL" but "list_size!=0" just do a

if (list == NULL) { list_size = 0; }

Second, parts of the patch go way beyond the 80-char limit.
I think introducing a helper variable might be overdue here.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list