[PATCH] More tdb/ldb tests.

[Adrian Cochrane]

I think I addressed all your issues with this code.

On Fri, Aug 21, 2015 at 12:24 PM, Andrew Bartlett <abartlet at samba.org> 
wrote:
> On Fri, 2015-08-21 at 09:54 +1200, Adrian Cochrane wrote:
>>  I've now moved the functions I was testing to be declared in
>>  ldb_module.h (in attachment 0001) and have also attached some
>>  additional tests (in attachment 0004) for Matthieu Patou's
>>  ldb_unpack_data_withlist (in attachments 0002 & 0003).
> 
> Thanks Adrian.
> 
> This is looking pretty good.  A few comments:
>  - We do not use C99 \\ comments in Samba, please convert these to
>    /* */
> 
>  - Please squash the fixes to torture_ldb_unpack into the first patch.
>  - Please split the formatting fix to torture_ldb_parse_ldif into a 
> new
> patch
>  - Please tidy up the ldb_parse.h change, it seems to have some
> commented out data that does not belong.
> 
> Once those are sorted out, I'm happy to give my review.  We will need
> to save the SDDL debugging for a time I can sit down with you, it 
> looks
> like the result of environmental factors (that is, if a sessionInfo
> token is set or not at the time).
> 
> Thanks,
> 
> Andrew Bartlett
> 
> --
> Andrew Bartlett
> https://samba.org/~abartlet/
> Authentication Developer, Samba Team         https://samba.org
> Samba Development and Support, Catalyst IT
> https://catalyst.net.nz/services/samba
> 
> 
> 
> 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ldb-introduce-ldb_unpack_data_withlist-to-unpack-par.patch
Type: text/x-patch
Size: 7124 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150821/5db9d851/0002-ldb-introduce-ldb_unpack_data_withlist-to-unpack-par.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ldif-increment-version-due-to-added-ldb_unpack_data_.patch
Type: text/x-patch
Size: 22211 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150821/5db9d851/0003-ldif-increment-version-due-to-added-ldb_unpack_data_.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-ldb-torture-test-ldb_unpack_data_withlist.patch
Type: text/x-patch
Size: 6986 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150821/5db9d851/0004-ldb-torture-test-ldb_unpack_data_withlist.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ldb-torture-Test-ldb-unpacking-and-printing.patch
Type: text/x-patch
Size: 27022 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150821/5db9d851/0001-ldb-torture-Test-ldb-unpacking-and-printing.bin>