[PATCH] More tdb/ldb tests.

Andrew Bartlett abartlet at samba.org
Fri Aug 21 00:24:27 UTC 2015

On Fri, 2015-08-21 at 09:54 +1200, Adrian Cochrane wrote:
> I've now moved the functions I was testing to be declared in 
> ldb_module.h (in attachment 0001) and have also attached some 
> additional tests (in attachment 0004) for Matthieu Patou's 
> ldb_unpack_data_withlist (in attachments 0002 & 0003).

Thanks Adrian.

This is looking pretty good.  A few comments:
 - We do not use C99 \\ comments in Samba, please convert these to 
   /* */

 - Please squash the fixes to torture_ldb_unpack into the first patch.
 - Please split the formatting fix to torture_ldb_parse_ldif into a new
 - Please tidy up the ldb_parse.h change, it seems to have some
commented out data that does not belong.

Once those are sorted out, I'm happy to give my review.  We will need
to save the SDDL debugging for a time I can sit down with you, it looks
like the result of environmental factors (that is, if a sessionInfo
token is set or not at the time). 


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list