[PATCH] Remove 'server role' lines from default smb.conf

[Andrew Bartlett]

On Wed, 2015-08-19 at 19:45 +0100, Rowland Penny wrote:
> HI, Samba ships a default smb.conf, this contains lines referring to 
> the 
> server role and a default line 'server role = standalone server'.
> 
> In 'man smb.conf', there is this about 'server role':
> 
>              This option determines the basic operating mode of a 
> Samba 
> server
>             and is one of the most important settings in the smb.conf 
> file.
> 
>             The default is server role = auto, as causes Samba to 
> operate
>             according to the security setting, or if not specified as 
> a 
> simple
>             file server that is not connected to any domain.
> 
> I do not think 'server role' should be set anywhere except on an AD 
> DC, 
> the attached patch removes the lines.

The behaviour described is there to ensure that we work with old
smb.conf files before this was specified. 

This new parameter was added to make it easier to set up all types of
servers, including standalone servers, and that is why we give it as
the suggested starting point in the example.

The old system is just an insane matrix of boolens that have no meaning
in themselves.  Parameters like 'security', 'domain master', and
'domain logons' have a meaning, but I added 'server role' so
administrators specify the desired outcome, not the method.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba