[PATCH] Two Coverity fixes and a few cleanups

[Volker Lendecke]

On Mon, Aug 17, 2015 at 09:02:15AM -0400, Ira Cooper wrote:
> Volker Lendecke <Volker.Lendecke at SerNet.DE> writes:
> 
> > Hi!
> >
> > Review&push appreciated!
> >
> > Thanks,
> >
> > Volker
> 
> I did a checkout at patch #2, and ctdb fails to build.
> 
> commit 83daf862c9e1b950a7a61cb14c9abb55669cd065
> Author: Volker Lendecke <vl at samba.org>
> Date:   Sun Aug 16 13:19:15 2015 +0200
> 
>     ctdb: Use talloc_report_str in ctdb
>     
>     This fixes CID 1125620 Insecure temporary file
>     
>     Signed-off-by: Volker Lendecke <vl at samba.org>
> 
> 
> ira at ira-t430:~/samba/clone_me/ctdb
> [/dev/pts/2](402/141)$ make -j4
> WAF_MAKE=1 PATH=buildtools/bin:../buildtools/bin:$PATH waf build
> Waf: Entering directory `/home/ira/samba/clone_me/ctdb/bin'
> Checking project rules ...
> Unknown dependency 'talloc_report' in 'ctdb_takeover_tests'
> Makefile:6: recipe for target 'all' failed
> make: *** [all] Error 1
> 
> I saw that the next patch adds some stuff to do with this...
> 
> ira at ira-t430:~/samba/clone_me/ctdb
> [/dev/pts/2](410/0)$ git show
> commit d05d378577e937c80986ca54b59647c891f0567d
> Author: Volker Lendecke <vl at samba.org>
> Date:   Sun Aug 16 20:25:31 2015 +0200
> 
>     ctdb: ctdb now needs talloc_report
>     
>     Signed-off-by: Volker Lendecke <vl at samba.org>
> 
> When I goto this commit, the build works.

Correct. Do you want me to squash those 3 patches?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de