[PATCH] Two Coverity fixes and a few cleanups
Ira Cooper
ira at wakeful.net
Mon Aug 17 13:02:15 UTC 2015
Volker Lendecke <Volker.Lendecke at SerNet.DE> writes:
> Hi!
>
> Review&push appreciated!
>
> Thanks,
>
> Volker
I did a checkout at patch #2, and ctdb fails to build.
commit 83daf862c9e1b950a7a61cb14c9abb55669cd065
Author: Volker Lendecke <vl at samba.org>
Date: Sun Aug 16 13:19:15 2015 +0200
ctdb: Use talloc_report_str in ctdb
This fixes CID 1125620 Insecure temporary file
Signed-off-by: Volker Lendecke <vl at samba.org>
ira at ira-t430:~/samba/clone_me/ctdb
[/dev/pts/2](402/141)$ make -j4
WAF_MAKE=1 PATH=buildtools/bin:../buildtools/bin:$PATH waf build
Waf: Entering directory `/home/ira/samba/clone_me/ctdb/bin'
Checking project rules ...
Unknown dependency 'talloc_report' in 'ctdb_takeover_tests'
Makefile:6: recipe for target 'all' failed
make: *** [all] Error 1
I saw that the next patch adds some stuff to do with this...
ira at ira-t430:~/samba/clone_me/ctdb
[/dev/pts/2](410/0)$ git show
commit d05d378577e937c80986ca54b59647c891f0567d
Author: Volker Lendecke <vl at samba.org>
Date: Sun Aug 16 20:25:31 2015 +0200
ctdb: ctdb now needs talloc_report
Signed-off-by: Volker Lendecke <vl at samba.org>
When I goto this commit, the build works.
Thanks,
-Ira
More information about the samba-technical
mailing list