[PATCHES] Port ldb to Python 3

Andrew Bartlett abartlet at samba.org
Sun Aug 16 23:17:02 UTC 2015

On Fri, 2015-08-14 at 13:07 +0200, Petr Viktorin wrote:
> Thanks.
> Here is a new version of the patchset. It includes a buildtools 
> change
> to replace the ABI tag by just ".py3". See the first patch.
> I've also moved the wscript patch to the end as discussed earlier in
> this thread, and I've squashed in Stefan's const-correctness fixes.

In the tests, can you extend the api.py testsuite to cover the whole

I realise you didn't add the APIs in the first place, but I'm
particularly concerned that the intersection between DNs and LdbValue
elements (which mix up between UTF8 strings and binary values in this
new world) could be a bit tricky.  We need tests that specifically aim
for the difficult parts of this, for:
 - ldb.Dn.{get,set}_{extended_,}component_{name,value}
 - ldb.Dn.{get,set}_rdn_{name,value}
 - ldb.Dn.get_casefold
 - ldb.Dn.get_linearized
 - ldb.Dn.canonical_str

(There are probably more missing tests, but these would seem to be the
main string related tests).


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list