[PATCH] smbd crash when change notify is disabled
Ralph Böhme
rb at sernet.de
Fri Aug 14 09:55:11 UTC 2015
Hi Michael,
On Fri, Aug 14, 2015 at 10:14:13AM +0200, Michael Adam wrote:
> On 2015-08-12 at 12:53 +0200, Ralph Böhme wrote:
> > Hi!
> >
> > Bug <https://bugzilla.samba.org/show_bug.cgi?id=11444> :
> >
> > If "change notify = no" is set in smb.conf, notify_ctx is
> > NULL. Then in file_free() we pass notify_ctx (= NULL) to
> > notify_remove() which doesn't check for that and crashes.
> >
> > Patch attached. Can someone please review and push if ok?
>
> This looks good to me, except for one thing:
>
> Could you use torture_assert_foobar macros in the test suite
> instead of adding yet another incarnation of CHECK_STATUS?
> (torture_assert_ntstatus_equal_goto() and
> torture_assert_ntstatus_ok_goto().)
RIP CHECK_STATUS. :) Pushed with this change. Thanks!
-Ralph
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de
More information about the samba-technical
mailing list