[PATCH] Fix format string in upgrade.py

Martin Schwenke martin at meltin.net
Fri Aug 14 05:51:07 UTC 2015


On Fri, 14 Aug 2015 17:38:58 +1200, Andrew Bartlett
<abartlet at samba.org> wrote:

> On Fri, 2015-08-14 at 15:16 +1000, Martin Schwenke wrote:
> > On Fri, 14 Aug 2015 15:07:55 +1000, Martin Schwenke <
> > martin at meltin.net>
> > wrote:
> > 
> > > On Fri, 14 Aug 2015 16:45:39 +1200, Andrew Bartlett
> > > <abartlet at samba.org> wrote:
> > > 
> > > > Not much more to say, but please review/push/cremate! ;-)
> > > 
> > > Reviewed, pushed.
> > 
> > Actually, cancelled.  Shouldn't it be as attached?
> 
> Indeed.  You can tell how well I tested that (this is why it is a
> problem, this code isn't in a tested path even as we don't have an ldap
> server to migrate from in the upgrade tests).

Hey, I pushed it the first time without testing...  I just read the code
more carefully after the autobuild started and there was a niggling
doubt in my mind.  :-)

Still haven't tested, but...

> Please push,

... done!

peace & happiness,
martin



More information about the samba-technical mailing list