PATCH: Moving the rejection of svhdx to vfs_default.c

Michael Adam obnox at samba.org
Thu Aug 13 08:17:10 UTC 2015


On 2015-08-13 at 10:08 +0200, Stefan Metzmacher wrote:
> Hi Richard,
> 
> > +	if (in_context_blobs)
> > +		svhdx = smb2_create_blob_find(in_context_blobs,
> > +					      SVHDX_OPEN_DEVICE_CONTEXT);
> 
> Please read README.Coding.
> 
> If statements should always have braces, this is a difference compared
> to the style of the linux kernel.
> 
> Regarding the functional change, I'm not sure.
> Please discuss this to the end with Michael,
> before pushing.

Thanks,

I will follow up on that later today.
Wasn't able to follow up earlier due to
being very busy/traveling.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150813/d78b8492/attachment.sig>


More information about the samba-technical mailing list