[PATCH] Compilation warning

Matthias Dieter Wallnöfer mdw at samba.org
Sat Aug 8 18:58:21 UTC 2015


This is a similar case.

Matthias Dieter Wallnöfer schrieb:
> Please find attached the patch. ULL literals on i386 need to be declared
> as such, otherwise they get truncated.
>
> Matthias
>
> Ira Cooper schrieb:
>> Any chance we can get the commit message etc?
>>
>> -Ira
>>
>> Matthias Dieter Wallnöfer <mdw at samba.org> writes:
>>
>>> Stumbled over when building on a 32 bit system. Please review!
>>>
>>> Matthias
>>> diff --git a/source4/torture/ndr/samr.c b/source4/torture/ndr/samr.c
>>> index 91bb4d7..589ce72 100644
>>> --- a/source4/torture/ndr/samr.c
>>> +++ b/source4/torture/ndr/samr.c
>>> @@ -294,8 +294,8 @@ static bool samr_changepassworduser3_w2k8r2_out_check(struct torture_context *tc
>>>  	torture_assert_int_equal(tctx, dominfo->min_password_length, 7, "min_password_length");
>>>  	torture_assert_int_equal(tctx, dominfo->password_history_length, 0, "password_history_length");
>>>  	torture_assert_int_equal(tctx, dominfo->password_properties, DOMAIN_PASSWORD_COMPLEX, "password_properties");
>>> -	torture_assert_u64_equal(tctx, dominfo->max_password_age, 0xffffdeff0aa68000, "max_password_age");
>>> -	torture_assert_u64_equal(tctx, dominfo->min_password_age, 0x0000000000000000, "min_password_age");
>>> +	torture_assert_u64_equal(tctx, dominfo->max_password_age, 0xffffdeff0aa68000ULL, "max_password_age");
>>> +	torture_assert_u64_equal(tctx, dominfo->min_password_age, 0x0000000000000000ULL, "min_password_age");
>>>  
>>>  	torture_assert_int_equal(tctx, reject->extendedFailureReason, SAM_PWD_CHANGE_NOT_COMPLEX, "extendedFailureReason");
>>>  	torture_assert_int_equal(tctx, reject->filterModuleName.length, 0, "filterModuleName.length");

-------------- next part --------------
A non-text attachment was scrubbed...
Name: operational.patch
Type: application/mbox
Size: 1141 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150808/1aa614e2/operational.mbox>


More information about the samba-technical mailing list