[PATCH] dns_server: Don't call tevent_req_finish twice
Ralph Böhme
rb at sernet.de
Fri Aug 7 10:02:20 UTC 2015
On Fri, Aug 07, 2015 at 08:03:12AM +0200, Volker Lendecke wrote:
> Hi!
>
> The attached patch is not tested, but I saw the sequence
>
> if (tevent_req_werror(req, err)) {
> if (!W_ERROR_EQUAL(err, DNS_ERR(NAME_ERROR))) {
> return tevent_req_post(req, ev);
> }
> }
> tevent_req_done(req);
> return tevent_req_post(req, ev);
>
> which calls both tevent_req_werror and tevent_req_done in
> case of NAME_ERROR. I believe this is not the right thing to
> do.
>
> Please review & potentially push!
reviewed & pushed.
-Ralph
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de
More information about the samba-technical
mailing list