Patch: Fixed patch for moving RSVD/SHVXD to vfs_default

Richard Sharpe realrichardsharpe at
Tue Aug 4 19:06:38 UTC 2015

On Tue, Aug 4, 2015 at 11:25 AM, Michael Adam <obnox at> wrote:
> Wait a minute ... the vfs should not be fiddling
> with smb2 create contexts! IMHO, this belongs into
> smb2_create.c and nowhere else.

Why? These are the same as Extra Create Parameters in Windows and they
belong in NTFS, AFAICT.

In addition, we already pass these to the VFS layer, and why should we
have to add code to the SMB layer for each new ECP/Create Context
Microsoft adds?

> If the smb(2) creat code has to tell the vfs layer something
> it should do so, by dedicated interfaces. If the current API
> does not provide such an interface, we should extend the API.
> So I'd rather not have this patch pushed but rethink the
> layering.

Richard Sharpe

More information about the samba-technical mailing list