[PATCH] Two small dns server fixes

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Aug 4 15:31:26 UTC 2015

On Tue, Aug 04, 2015 at 03:15:52PM +0200, Kai Blin wrote:
> On 2015-08-01 18:03, Volker Lendecke wrote:
> Hi Volker,
> >  	case DNS_QTYPE_PTR:
> >  		ans[ai].rdata.ptr_record = talloc_strdup(ans, rec->data.ptr);
> >+		W_ERROR_HAVE_NO_MEMORY(ans[ai].rdata.ptr_record);
> >  		break;
> I thought we're not using these macros anymore? I keep getting
> yelled at if I'm adding new instances. :)
> Apart from this, it's obviously correct.

Well, this time I've chosen consistency across the file over
strict rules. The whole routine uses this macro all over the
place, and to me it seemed cleaner to keep the style than to
enforce a rule. If you disagree, feel free to propose a
separate patch over this.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list