[PATCHv2] Some coverity fixes

Anoop C S anoopcs at redhat.com
Mon Aug 3 08:49:24 UTC 2015


On Mon, 2015-08-03 at 10:16 +0200, Stefan Metzmacher wrote:
> Hi Anoop,
> 
> > Reviews are welcome.
> 
> Can you please tabs instead of whitespaces?
> 

I have changed white spaces to tabs. Please see the updated version
attached along with this message.

> The change to uwrap_thread_child() seems to be wrong:
> uwrap_thread_prepare() takes the locks,
> while uwrap_thread_parent() and uwrap_thread_child()
> unlock.
> 

Thanks. So removing the same from attached patches.

--Anoop C S.

> The other patches look good to me Reviewed-by: me
> 
> metze
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lib-talloc-Fix-CID-1291640-Missing-unlock.patch
Type: text/x-patch
Size: 686 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150803/09d2ab19/0002-lib-talloc-Fix-CID-1291640-Missing-unlock.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-lib-talloc-Fix-CID-1291639-Missing-unlock.patch
Type: text/x-patch
Size: 706 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150803/09d2ab19/0003-lib-talloc-Fix-CID-1291639-Missing-unlock.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-source3-rpc_client-Fix-CID-1273041-Condition-is-redu.patch
Type: text/x-patch
Size: 965 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150803/09d2ab19/0004-source3-rpc_client-Fix-CID-1273041-Condition-is-redu.bin>


More information about the samba-technical mailing list