[PATCHES] more loadparm cleanup

[Ira Cooper]

LGTM.

Reviewed-by: Ira Cooper <ira at samba.org>

-Ira

On Thu, Apr 30, 2015 at 5:59 PM, Michael Adam <obnox at samba.org> wrote:

> Attached the updated patchset:
>
> - removal of META and other flags squashed
>   (and commit message amended)
> - removal of flags from xml files squashed
> - SEP removal patch does not add comments
>
> Have I forgotten anything?
>
> Cheers - Michael
>
> On 2015-04-30 at 23:01 +0200, Michael Adam wrote:
> > On 2015-04-30 at 16:58 -0400, Ira Cooper wrote:
> > > On Thu, Apr 30, 2015 at 4:44 PM, Michael Adam <obnox at samba.org> wrote:
> > >
> > > > On 2015-04-30 at 15:48 -0400, Ira Cooper wrote:
> > > > > On Thu, Apr 30, 2015 at 1:42 PM, Michael Adam <obnox at samba.org>
> wrote:
> > > > > > On 2015-04-30 at 07:48 -0400, Ira Cooper wrote:
> > > > > >
> > > > > > > 03/22 Need to make sure the case matches in patch.
> > > > > >
> > > > > > Er, what do you mean here?
> > > > > > That's the P_SEP patch.
> > > > > >
> > > > > >
> > > > > That the comments put in, should have the same case as the
> parameter you
> > > > > were removing...
> > > >
> > > > Nah, ... seriously? ;)
> > > >
> > > > I actually thought just removing the SEP entries without
> > > > replacing them by comments. I think the assignments are
> > > > to these categories are not correct in all places anyways.
> > > > And I hope to get rid of the hand-crafted parm_table soon
> > > > anyways (almost done with autogenerating it):
> > > >
> > > > Should we just omit the comments?
> > >
> > >
> > > I'd support that.
> > >
> > > It just felt "strange" to put in different text than was there.
> >
> > Thanks for the comments!
> >
> > I will shortly follow up with a patchset that incorporates the
> > discussed changes.
> >
> > Michael
>
>
>