[PATCHES] more loadparm cleanup
Ira Cooper
ira at samba.org
Thu Apr 30 14:58:42 MDT 2015
On Thu, Apr 30, 2015 at 4:44 PM, Michael Adam <obnox at samba.org> wrote:
> On 2015-04-30 at 15:48 -0400, Ira Cooper wrote:
> > On Thu, Apr 30, 2015 at 1:42 PM, Michael Adam <obnox at samba.org> wrote:
> > > On 2015-04-30 at 07:48 -0400, Ira Cooper wrote:
> > >
> > > > 03/22 Need to make sure the case matches in patch.
> > >
> > > Er, what do you mean here?
> > > That's the P_SEP patch.
> > >
> > >
> > That the comments put in, should have the same case as the parameter you
> > were removing...
>
> Nah, ... seriously? ;)
>
> I actually thought just removing the SEP entries without
> replacing them by comments. I think the assignments are
> to these categories are not correct in all places anyways.
> And I hope to get rid of the hand-crafted parm_table soon
> anyways (almost done with autogenerating it):
>
> Should we just omit the comments?
I'd support that.
It just felt "strange" to put in different text than was there.
-Ira
More information about the samba-technical
mailing list