[PATCH] Fix build on Illumos

Michael Adam obnox at samba.org
Wed Apr 29 14:58:41 MDT 2015


On 2015-04-29 at 13:50 -0700, Jeremy Allison wrote:
> On Wed, Apr 29, 2015 at 09:27:42PM +0200, Michael Adam wrote:
> > Hi Jeremy,
> > 
> > did you intentionally put yourself as author
> > but add signoff br Ross and review by you?
> 
> Nope, sorry :-). I'll fix it.
> 
> > Otherwise, for the first patch, wouldn't it
> > be more clean to have the declaration of ret
> > inside the scope of the for loop?
> 
> Fair enough... I'll fix before submit.

Thanks - you can add my r-b as well.

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150429/70a5da6e/attachment.pgp>


More information about the samba-technical mailing list