rpc_server crash in samba master

[Jeremy Allison]

On Fri, Apr 24, 2015 at 12:43:20PM -0700, Jeremy Allison wrote:
> On Fri, Apr 24, 2015 at 01:08:39PM +0200, Julien Kerihuel wrote:
> > Karolin,
> > 
> > We have found a crash in samba caused by my recent patches.
> > 
> > There was a missing check in alter_context function that was causing
> > samba to crash when an unregistered/unknown endpoint was queried by the
> > client.
> > 
> > I have created the bug entry on bugzilla and attached the patch to fix
> > the problem.
> > https://bugzilla.samba.org/show_bug.cgi?id=11236
> > 
> > Can you please follow-up on this before shipping next samba release?
> > 
> > Let me know if there is anything I can do to help you with this.
> 
> OMG the code inside dcesrv_alter() is *horrible*.
> 
> This *desperately* needs refactoring to split
> out the !dcesrv_auth_alter(call) case into
> a separate function IMHO.
> 
> Hand on a minute whilst I do that...

Here it is. Julian, can you confirm this fixes
your problem ?

If so, then I'll get a second Team reviewer.

Cheers,

	Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-rpc-Refactor-dcesrv_alter-function-into-setup-and.patch
Type: text/x-diff
Size: 5387 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150424/a8f12ac5/attachment.patch>