[RFC PATCH] s3: libsmbclient: Add server-side copy support

Jeremy Allison jra at samba.org
Tue Apr 21 18:00:28 MDT 2015


On Fri, Apr 17, 2015 at 06:30:33AM +0100, Ross Lagerwall wrote:
> On Thu, Apr 16, 2015 at 03:55:47PM -0700, Jeremy Allison wrote:
> > On Mon, Apr 13, 2015 at 12:55:59AM +0200, David Disseldorp wrote:
> > > Hi Ross,
> > > 
> > > A few comments inline...
> > 
> > Ping Ross. We'd love to get this code into Samba !
> > 
> > Didn't want you to think we'd forgotten :-).
> > 
> 
> Thanks for the comments.  Sorry, I can't get to this sooner as I'm going
> to be travelling for a couple of weeks.  In terms of the API itself,
> does it seem reasonable? (the comments were mainly regarding details of
> the patch)

Yes the API looks very reasonable.

> Also, this will only be useful if libsmbclient were threadsafe, which I
> haven't yet looked into.

libsmbclient is not fully threadsafe yet. It's safe if
separate client contexts are used by separate threads, but
not if they're shared :-(.

Patches welcome on that, but that is a very hard task..


More information about the samba-technical mailing list