Patch: Change uint32 to uint32_t in vfs.h
jra at samba.org
Fri Apr 17 14:17:36 MDT 2015
On Tue, Apr 14, 2015 at 08:54:34AM +0200, Andreas Schneider wrote:
> On Monday 13 April 2015 17:03:06 Richard Sharpe wrote:
> > On Mon, Apr 13, 2015 at 5:01 PM, Richard Sharpe
> > <realrichardsharpe at gmail.com> wrote:
> > > Hi folks,
> > >
> > > I was extremely shocked to find that there are around 104 instances of
> > > uint32 in our code.
> > >
> > > Here is a patch that changes 17 of them to uint32_t.
> > >
> > > If this sort of thing is welcome, I will fix the rest.
> > So shocked, in fact, that I forgot to include the patch:
> And yes, we should fix them all. We just fixed them slowly when we worked on
> code which still does not use stdint types.
NAK on this one, sorry. It changes the vfs.h types, but
not the ones in the .c files. Can you do both at once ?
I know they end up as the same underlying type, but doing
only .h and not .c's leaves the code looking 'strange' :-).
More information about the samba-technical