[PATCH] caching optimization in share mode locks.

Ira Cooper ira at samba.org
Fri Apr 17 00:28:50 MDT 2015


Reviewed-by: Ira Cooper <ira at samba.org>

I'd be interested in if these changes affected the overall performance
results.

Thanks,

-Ira

On Fri, Apr 17, 2015 at 5:24 AM, Jeremy Allison <jra at samba.org> wrote:

> On Tue, Apr 14, 2015 at 06:08:54PM -0700, Jeremy Allison wrote:
> >
> > OK, I think I've figured out a way to do all this
> > reasonably cleanly. I should have a version 2 for
> > people to look at this week.
>
> OK, here's the updated version:
>
> Changes from the previous version:
>
> 1). No longer uses sequence number as the memcache key (doh!).
> Now uses the locking key used in the normal tdb as the
> memcache lookup value. Should prevent any orphaned records
> in the memcache.
>
> 2). Uses ndr_pull_hyper() to get at the sequence record
> in the blob, rather than doing dodgy memcpy from the
> start of the blob.
>
> Jeremy.
>


More information about the samba-technical mailing list