[PATCH] Fix bug #11177 - no talloc stackframe at ../source3/libsmb/clifsinfo.c:444, leaking memory
jra at samba.org
Thu Apr 16 12:49:39 MDT 2015
On Tue, Apr 14, 2015 at 12:28:36PM +0200, Volker Lendecke wrote:
> On Tue, Apr 14, 2015 at 05:28:53PM +1200, Andrew Bartlett wrote:
> > Do we still get that when each function has a talloc_stackframe(), and
> > talloc_tos() is never called? That is all I'm really looking for.
> Attached find a patchset that I just want to provide as an
> example where I'm right now going for optimiziation: A lot
> of talloc_tos() users can be removed with the variable
> arrays in the second patch. C99 gives us this nice feature.
> I am aware that this only covers a fraction of all
> talloc_tos users, but it is a start.
> The first patch is a simple conversion from tdb_fetch to
> tdb_parse. This from my point of view is also simpler and
> removes one user of the bad tdb_fetch API.
> With -O3 on 64 bit this patchset shrinks the object code
> size by 656 bytes, a value in itself.
> Review & push appreciated!
LGTM - pushed !
More information about the samba-technical