A patch a day ... Use unit32_t in the registry subsystem ...

Jeremy Allison jra at samba.org
Tue Apr 14 10:04:41 MDT 2015


On Tue, Apr 14, 2015 at 05:24:57PM +0200, Volker Lendecke wrote:
> On Tue, Apr 14, 2015 at 07:53:01AM -0700, Richard Sharpe wrote:
> > -- 
> > Regards,
> > Richard Sharpe
> > (何以解憂?唯有杜康。--曹操)
> 
> > From 2cf66207561b8f078f00a29bb532f63a7928a208 Mon Sep 17 00:00:00 2001
> > From: Richard Sharpe <rsharpe at samba.org>
> > Date: Tue, 14 Apr 2015 07:50:28 -0700
> > Subject: [PATCH] Change the registrty subsystem to use uint32_t from uint32.
> >  Also change session.h.
> > 
> > Builds OK.
> 
> Question: What's so bad about uint32 that we need to fix it
> with sweeping changes?

It is a Samba-ism that looks strange from anyone coming
to our code from standards-based projects, so it's good
to move to a more common use.

I don't think these cleanups are harmful and they do make the
master code slightly better in the long run.

Just my 2 cents :-).


More information about the samba-technical mailing list